refactor: remove unnecessary object spread in conditionalGeneration.js

[Satya900]

Description

I noticed a small code smell in
apps/generator/lib/conditionalGeneration.js.

There was an object literal being spread inside another object literal unnecessarily.

This PR refactors the code to define the property directly, improving readability and removing a redundant operation.

---

Changes

• Removed unnecessary object spread in conditionalGeneration.js.
• Fixed bug: Passed missing templateParams to conditionalSubjectGeneration (was causing a crash).

---

Related Issue

Resolves issue #1911

---

Verification

I manually verified the changes using a mocked script because the test suite was skipping this code path.

The logic now correctly handles conditional generation without crashing.

---

Checklist

• I have performed a self-review of my own code.
• I have verified that the changes do not break existing functionality.

Summary by CodeRabbit

• Refactor
  • Internal adjustments to parameter handling and object construction; minor formatting cleanup. No changes to public interfaces, control flow, or error handling. User-facing behavior and functionality remain unchanged.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2f44a52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[asyncapi-bot]

What reviewer looks at during PR review

The following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.

1. PR Title: Use a concise title that follows our Conventional Commits guidelines and clearly summarizes the change using imperative mood (it means spoken or written as if giving a command or instruction, like "add new helper for listing operations")

   Note - In Generator, prepend feat: or fix: in PR title only when PATCH/MINOR release must be triggered.

2. PR Description: Clearly explain the issue being solved, summarize the changes made, and mention the related issue.

   Note - In Generator, we use Maintainers Work board to track progress. Ensure the PR Description includes Resolves #<issue-number> or Fixes #<issue-number> this will automatically close the linked issue when the PR is merged and helps automate the maintainers workflow.

3. Documentation: Update the relevant Generator documentation to accurately reflect the changes introduced in the PR, ensuring users and contributors have up-to-date guidance.

4. Comments and JSDoc: Write clear and consistent JSDoc comments for functions, including parameter types, return values, and error conditions, so others can easily understand and use the code.

5. DRY Code: Ensure the code follows the Don't Repeat Yourself principle. Look out for duplicate logic that can be reused.

6. Test Coverage: Ensure the new code is well-tested with meaningful test cases that pass consistently and cover all relevant edge cases.

7. Commit History: Contributors should avoid force-pushing as much as possible. It makes it harder to track incremental changes and review the latest updates.

8. Template Design Principles Alignment: While reviewing template-related changes in the packages/ directory, ensure they align with the Assumptions and Principles. If any principle feels outdated or no longer applicable, start a discussion these principles are meant to evolve with the project.

9. Reduce Scope When Needed: If an issue or PR feels too large or complex, consider splitting it and creating follow-up issues. Smaller, focused PRs are easier to review and merge.

10. Bot Comments: As reviewers, check that contributors have appropriately addressed comments or suggestions made by automated bots. If there are bot comments the reviewer disagrees with, react to them or mark them as resolved, so the review history remains clear and accurate.

[coderabbitai]

📝 Walkthrough

Walkthrough

isGenerationConditionMet now forwards templateParams when delegating to conditionalSubjectGeneration; conditionalParameterGeneration usage was not changed. Also simplified the server object construction used in a jmespath search and made minor formatting edits; no public signatures or control flow changes.

Changes

Cohort / File(s)	Summary
Conditional generation logic apps/generator/lib/conditionalGeneration.js	isGenerationConditionMet now passes templateParams to conditionalSubjectGeneration. Simplified server-object construction inside a jmespath search (removed extra wrapper). Minor whitespace/formatting edits around validateStatus code paths. No exported signature changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title follows Conventional Commits guidelines with 'refactor:' prefix, uses imperative mood ('remove'), and clearly summarizes the main change: removing unnecessary object spread in the file.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into master

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Adi-204]

@Satya900 please revert all the unnecessary formatting changes. We already have linting in the codebase and if it is not complaining, I don't think there is much point to format manually.

[Satya900]

@Adi-204 sure i will revert the formatting changes

[Satya900]

@Adi-204 i have removed the unnecessary formatting. You can review this again

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[derberg]

/rtm