fix: implement uuid format for string#72
fix: implement uuid format for string#72asyncapi-bot merged 4 commits intoasyncapi:masterfrom dan-r:uuid
Conversation
dan-r
requested review from
AGurlhosur,
JEFFLUFC,
KieranM1999,
asyncapi-bot-eve,
dalelane and
lewis-relph
as code owners
dan-r
changed the title
dan-r
changed the title
|
Just realised this conflicts with @dalelane's latest changes, let me rework... |
| return 'String'; | ||
| case 'password': | ||
| return 'String'; | ||
| case 'uuid': |
There was a problem hiding this comment.
uuid isn't a format in the AsyncAPI spec but it's commonly used enough that it seems reasonable to add
We'll need to update the template to add java.util.UUID to the imports for any class that uses it, though - as it's not a primitive
There was a problem hiding this comment.
@dalelane worth importing java.util.UUID regardless or doing it conditionally?
There was a problem hiding this comment.
depends on how much effort it would be, I guess - it'd be nice to not add unused imports, but it wouldn't cause errors so it's not worth a massive amount of work, IMO
There was a problem hiding this comment.
I've just imported it for now, but I think a future task is to cleanup how we do this, as its likely future datatypes will make this more of an issue
|
/rtm |
|
🎉 This PR is included in version 0.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Description
Implementing UUID format for string type
Related issue(s)
#23