feat: cross-container tab dragging in split-pane layout - #128
Merged
Conversation
Enable dragging tabs between leaf containers in the split-pane layout. Tabs are now draggable via the existing DragContext + DropZoneOverlay infrastructure — drop on center to add as tab, drop on edges to split. - Add draggable + onDragStart/onDragEnd handlers to TabBar tabs - Reuse sidebar's DragContext pattern (startDrag/endDrag) - Dim only the dragged tab (0.5 opacity) during drag - DropZoneOverlay already handles existing-pane moves via movePaneToLeaf - Same-leaf drops correctly suppressed by DropZoneOverlay Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How it works
The implementation is minimal (single file change) because it leverages the existing drag infrastructure:
graph LR A[TabBar<br/>onDragStart] -->|startDrag| B[DragContext<br/>isDragging=true] B --> C[SessionMountLayer<br/>pointerEvents=none] B --> D[DropZoneOverlay<br/>shows drop zones] D -->|existing pane| E[movePaneToLeaf<br/>removes from source<br/>adds to target] D -->|new pane| F[splitLeafWithPane<br/>or addTabToLeaf]The same
DragContext→DropZoneOverlay→movePaneToLeafpipeline used by sidebar drag now also handles tab drag. No new components or store actions needed.Changes
packages/dashboard/src/layout/TabBar.tsx— Adddraggable,onDragStart,onDragEndhandlers to tab elements. Wire into existing DragContext. Visual feedback: dimmed opacity on dragged tab, grab cursor.Test plan
🤖 Generated with Claude Code