fix: drag crash, backward compat, MCP input validation by aterrylu · Pull Request #131 · aterrylu/autonomOS

aterrylu · 2026-04-14T02:57:58Z

Summary

Three reliability fixes affecting daily use:

Drag crash (black screen): All .toLowerCase() calls in sidebar hierarchy rendering now have null guards — prevents TypeError when org nodes have undefined names during drag reorder
Version upgrade breaks hierarchy: Relaxed readSessions() validation to not require autonomousMode field (old sessions lack it), added defaults for missing fields (persistedAt, autonomousMode), guarded buildOrgChart() against nameless sessions
MCP kill_agent arg confusion: kill_agent and set_manager now accept name as alias for agent parameter, with helpful error messages instead of "Agent undefined not found". Both HTTP and channel server handlers updated, tool schemas match runtime behavior.

Changes

File	What
`Sidebar.tsx`	Null guards on 11 `.toLowerCase()` calls, defensive `children ?? []`, safe `key` props
`orgChart.ts`	Skip nameless sessions in `buildOrgChart()`, default name to "Unknown" in `toNode()`
`persisted.ts`	Relax validation (only require 3 essential fields), default `autonomousMode`/`persistedAt`, guard `updatePersistedSessionByName`
`mcp.ts`	`kill_agent` + `set_manager`: accept `name` alias, input validation, helpful errors
`channel-server/index.ts`	Same `name` alias + validation for `kill_agent`, `set_manager`, `send`
`mcp/tools.ts`	Update `TOOL_KILL_AGENT` + `TOOL_SET_MANAGER` schemas to declare `name` property
`mcp-tools.test.ts`	Update test for new schema (no required `agent`, both params optional)

Test plan

make check — 70/70 tests pass, biome clean, tsc clean
Drag agents in hierarchy view — should NOT crash
Test with old session format (missing status, template, autonomousMode) — hierarchy should render
kill_agent(name: "X") — should work (not "Agent undefined not found")
kill_agent() with no params — should return helpful usage message

🤖 Generated with Claude Code

nox-0x · 2026-04-14T02:59:57Z

@@ -598,7 +604,7 @@ export function Sidebar() {



🟢 Suggestion

Problem: Using as a React fallback when is undefined (lines 604, 1297) means React treats these elements as new nodes every render, causing unnecessary DOM re-creation and potential animation glitches during drag-reorder animations.

Why it matters: Minor performance/stability issue during reorder — the crash is fixed, but the key instability could cause subtle UI jank or animation flicker when dragging nameless nodes.

Suggested fix:
If possible, generate a stable synthetic key when is absent — e.g. use a hash of or a monotonically increasing ID:

If is also absent (unlikely), fall back to for that case only.

Fixed in 63396b1 — now using claudeSessionId as key fallback instead of index, with a prefixed string fallback (node-N, child-N) as last resort.

nox-0x

Three solid fixes: null guards prevent drag crashes, backward-compat defaults handle old session formats gracefully, and MCP tool input validation with helpful error messages replaces confusing undefined errors. Left one non-blocking suggestion about React key stability for anonymous nodes. LGTM ✅

nox-0x · 2026-04-14T03:05:11Z

+        .string()
+        .optional()
+        .describe("Agent name (e.g. 'Dashboard@autonomOS')"),
+      name: z


🟡 Warning

Problem: set_manager error message says "Missing required parameter 'agent'" (line ~217), but agent is declared optional in the schema — neither agent nor name is actually required. The error message is therefore inconsistent with the schema contract.

Why it matters: MCP clients using schema-based validation will be confused if they see "Missing required 'agent'" after already omitting it intentionally. It undermines trust in the error messages.

Suggested fix:

`Missing required parameter. Usage: set_manager(agent: "AgentName", manager: "ManagerName")`

Same fix applies to `kill_agent's error on line ~165.

Fixed in 63396b1 — error messages now say "provide 'agent' or 'name'" instead of claiming agent is required. Applied to both kill_agent and set_manager in both MCP transports.

nox-0x

Good fixes overall. Left one non-blocking inline comment about misleading error message wording (parameter declared optional but error says "required agent"). Solid backward-compat tests and null guards. LGTM ✅

Three reliability fixes: 1. Sidebar drag crash: add null guards on all .toLowerCase() calls in hierarchy rendering — prevents TypeError when org nodes have undefined names during drag reorder. 2. Backward compatibility: relax readSessions() validation to not require autonomousMode (old sessions lack it), default missing fields (persistedAt, autonomousMode), and guard buildOrgChart() against nameless sessions. 3. MCP kill_agent/set_manager: accept 'name' as alias for 'agent' parameter (agents naturally try it), add input validation in both HTTP and channel server handlers, update tool schemas to match runtime behavior, and return helpful error messages instead of "Agent undefined not found". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- backward-compat.test.ts: 8 tests verifying old session formats (missing autonomousMode, persistedAt, status) load correctly and appear in org chart - mcp-validation.test.ts: 7 tests verifying kill_agent and set_manager schemas declare name alias and don't require agent Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Tests now save/restore the entire sessions.json instead of writing raw entries alongside real data. Fixes ENOENT on CI (no ~/.autonomos/) and test pollution between suites. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

nox-0x

Solid fixes. Null guards resolve the drag crash, backward-compat defaults handle old sessions correctly, and MCP input validation with name alias is clean. Backward compat test suite is a nice addition. One non-critical note: the kill_agent/set_manager error messages still say "Missing required parameter 'agent'" even though agent is now optional in the schema — consider updating to "Missing required parameter. Usage: kill_agent(agent: "..." | name: "...")" to match the dual-parameter contract. Not blocking. LGTM ✅

- Use claudeSessionId as React key fallback instead of index (avoids DOM re-creation during drag-reorder of nameless nodes) - Error messages now say "provide 'agent' or 'name'" instead of "Missing required parameter 'agent'" (consistent with optional schema) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Three critical fixes for production data loss: 1. Resume doesn't clear exited status: createSession() now passes status: "running" to persistSession(), so the merge logic no longer preserves the stale "exited" status on resume. 2. Test isolation: Tests from PR #131 wrote to production sessions.json. All test files now use isolated temp directories via _setConfigDirForTesting() / _resetCacheForTesting(). Added getConfigDir() with test override support to configDir.ts. 3. Write race on sessions.json: Added in-memory cache to persisted.ts — readSessions() populates once, all mutations go through the cached array, eliminating TOCTOU races. Added backup-on-shrink before destructive writes. getPersistedSessions() returns a defensive copy to prevent external cache corruption. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…134) Three critical fixes for production data loss: 1. Resume doesn't clear exited status: createSession() now passes status: "running" to persistSession(), so the merge logic no longer preserves the stale "exited" status on resume. 2. Test isolation: Tests from PR #131 wrote to production sessions.json. All test files now use isolated temp directories via _setConfigDirForTesting() / _resetCacheForTesting(). Added getConfigDir() with test override support to configDir.ts. 3. Write race on sessions.json: Added in-memory cache to persisted.ts — readSessions() populates once, all mutations go through the cached array, eliminating TOCTOU races. Added backup-on-shrink before destructive writes. getPersistedSessions() returns a defensive copy to prevent external cache corruption. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

nox-0x reviewed Apr 14, 2026

View reviewed changes

nox-0x approved these changes Apr 14, 2026

View reviewed changes

nox-0x reviewed Apr 14, 2026

View reviewed changes

nox-0x approved these changes Apr 14, 2026

View reviewed changes

aterrylu and others added 4 commits April 13, 2026 20:09

chore: trigger CI

a648eb5

aterrylu force-pushed the terry/reliability-fixes branch from fe61872 to a648eb5 Compare April 14, 2026 03:10

nox-0x approved these changes Apr 14, 2026

View reviewed changes

aterrylu marked this pull request as ready for review April 14, 2026 03:13

aterrylu merged commit ee3f855 into main Apr 14, 2026
1 check passed

aterrylu deleted the terry/reliability-fixes branch April 14, 2026 03:13

Navigation Menu

fix: drag crash, backward compat, MCP input validation - #131

fix: drag crash, backward compat, MCP input validation#131
aterrylu merged 5 commits into
mainfrom
terry/reliability-fixes

aterrylu commented Apr 14, 2026

Uh oh!

nox-0x Apr 14, 2026

Uh oh!

aterrylu Apr 14, 2026

Uh oh!

nox-0x left a comment

Uh oh!

nox-0x Apr 14, 2026

Uh oh!

aterrylu Apr 14, 2026

Uh oh!

nox-0x left a comment

Uh oh!

nox-0x left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aterrylu commented Apr 14, 2026

Summary

Changes

Test plan

Uh oh!

nox-0x Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

aterrylu Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

nox-0x left a comment

Choose a reason for hiding this comment

Uh oh!

nox-0x Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

aterrylu Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

nox-0x left a comment

Choose a reason for hiding this comment

Uh oh!

nox-0x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants