fix: onboarding UX — auth hint + default MCP channels - #146
Merged
Conversation
nox-0x
approved these changes
Apr 15, 2026
nox-0x
left a comment
nox-0x
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — clean fix. The res.ok narrowing and channels defaulting are both correct and well-reasoned. Ship it.
Two P0 onboarding fixes for new users: 1. Auth dead-end (#25): Login page now shows where to find the auth token (server console or ~/.autonomos/token). Also distinguishes network errors ("Cannot reach server") from invalid tokens. 2. Missing MCP tools (#26): Default channels ["server:autonomos"] now applied in getSettings() instead of only in the API response layer. This ensures createSession() always injects the channel server and MCP config, so agents created from the UI get autonomOS tools out of the box. Closes #25, closes #26 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add 12 unit tests covering getSettings() default channel behavior: no file, missing key, null channels, explicit empty array, custom channels, invalid JSON shapes, and updateSettings round-trips - Fix channels: null edge case (use == null to catch both null and undefined) - Warn on valid-JSON-but-wrong-shape settings file - Distinguish network errors from invalid tokens on login page Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aterrylu
force-pushed
the
terry/onboarding-fixes
branch
from
April 15, 2026 04:06
3188ae9 to
efb4365
Compare
aterrylu
marked this pull request as ready for review
April 15, 2026 04:07
nox-0x
approved these changes
Apr 15, 2026
nox-0x
left a comment
nox-0x
left a comment
Collaborator
There was a problem hiding this comment.
LGTM ✅ — auth error distinction is correct, default channels in getSettings() is the right fix, comprehensive test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two P0 onboarding fixes that unblock new users:
Auth dead-end (fix: terminal UX — scroll, focus, and mobile keyboard #25): Login page now tells users where to find their token — server console output or
~/.autonomos/token. Also fixes a pre-existing bug where network errors showed "Invalid token" instead of "Cannot reach server".Missing MCP tools (feat: pinned sessions, drag-to-reorder, Codicon icons #26): Default channels
["server:autonomos"]now applied ingetSettings()instead of only in the API response layer. Previously,createSession()sawundefinedchannels when nosettings.jsonexisted, so agents spawned from the UI never got--mcp-configor--dangerously-load-development-channels.Changes
packages/dashboard/src/App.tsxpackages/server/src/settings.tsgetSettings(), warn on malformed settingspackages/server/src/routes/settings.tsTest plan
~/.autonomos/settings.json— verify login page shows token location hintchannels: []in settings — verify agents spawn without MCP tools (opt-out works)Closes #25, closes #26
🤖 Generated with Claude Code