fix: instant terminal switching — keep sessions alive (VSCode-style) - #23
Merged
Conversation
Replace destroy-and-recreate pattern with persistent session views.
All terminal instances stay alive in memory; switching sessions just
toggles container visibility. Eliminates violent redraw/flashing.
- SessionViewManager: renders all live sessions, toggles display
- SessionPane: extensible view container per session (terminal now,
VNC/graphics views in the future)
- useTerminal: takes explicit sessionId param for multi-instance use
- Remove TerminalView (replaced by SessionPane)
- Remove key={sessionId} from App.tsx (was forcing remounts)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
SessionPanefor each live session, only the active one is visiblesessionIdparam so multiple instances coexistTerminalViewcomponent andkey={sessionId}forced remountBefore
Session switch → unmount terminal → close WebSocket → mount new terminal → new WebSocket → replay 1MB buffer → flash
After
Session switch →
display: noneon old →display: blockon new → instantTest plan
🤖 Generated with Claude Code