feat(dashboard): distinct highlight for co-visible sidebar rows - #269
Merged
Conversation
When panes share a dockview group, the focused agent gets the gold active ring;
the other on-screen members previously had a near-invisible `${page.border}80`
fill. They now get a neutral (page.fg) outline ring + faint fill via a new
`visibleHighlight()` helper — same ring affordance as the active highlight but a
quieter, different color (no glow — that stays the focus signal) — so grouped
panes read as "also here, just not focused." Applied at both render sites (flat
preview row + hierarchy SessionRow); theme-foreground-derived so it inverts on
light themes. Co-visible style chosen by Terry from rendered mockups (option B).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MGMW4cbhv5Le8wka7Th8bS
aterrylu
enabled auto-merge (squash)
June 29, 2026 04:59
nox-0x
approved these changes
Jun 29, 2026
nox-0x
left a comment
nox-0x
left a comment
Collaborator
There was a problem hiding this comment.
Approving — purely visual: new visibleHighlight helper cleanly replaces the old ${page.border}80 fill at both sidebar render sites (flat preview row and SessionRow), wired through page.fg so it inverts on light themes. Logic is a straightforward extension of the existing isActive ? activeHighlight(accent) : null pattern, no new state, no regressions to the active/drop-target compositing in rowBoxShadow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When several agents share a dockview group (a workspace), the focused one gets the gold active ring — but the other on-screen members of that group got only a near-invisible fill (
\${page.border}80). This gives them a clear, distinct treatment so grouped panes read as "also here, just not focused."Change
visibleHighlight(neutral)helper: a neutral (themepage.fg) outline ring + faint fill — the same ring affordance as the active gold highlight, but a quieter, different color. No glow (the glow stays reserved as the focus signal).SessionRow) through it; replaces the old faint\${page.border}80visible fill.The treatment (option B) was chosen by Terry from rendered mockups of the real void-theme colors (current / dimmer-gold / neutral-white / cyan).
Three sidebar states now: gold ring + glow = focused · neutral ring + faint fill = co-visible in the group · transparent = not on screen.
Testing
make checkgreen (biome + tsc + 227 dashboard tests). Visual matches the approved mockup (4% fill / 30% ring,page.fg-derived).🤖 Generated with Claude Code
https://claude.ai/code/session_01MGMW4cbhv5Le8wka7Th8bS