Skip to content

feat: align void theme with VSCode Pitch Black - #5

Merged
aterrylu merged 1 commit into
mainfrom
terry/void-pitch-black
Mar 8, 2026
Merged

feat: align void theme with VSCode Pitch Black#5
aterrylu merged 1 commit into
mainfrom
terry/void-pitch-black

Conversation

@aterrylu

@aterrylu aterrylu commented Mar 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Update void theme to match VSCode Pitch Black Theme colors
  • Terminal ANSI colors now use VSCode's Dark+ palette (softer, more muted tones)
  • Gray cursor replaces neon green for a neutral aesthetic
  • Blue selection (#007acc) matches VSCode's default
  • Subtle border (#1a1a1a) keeps UI structure visible without breaking the all-black look

Test plan

  • Switch to Void theme — terminal and page should feel like VSCode Pitch Black
  • Verify text readability across terminal colors (ls --color, git diff, etc.)
  • Confirm Midnight and Daylight themes are unaffected

🤖 Generated with Claude Code

Update the void theme colors to match the VSCode Pitch Black Theme:
- Terminal colors now use VSCode Dark+ ANSI palette
- Gray cursor instead of neon green (matches Pitch Black's neutral feel)
- Blue selection background (#007acc) matching VSCode's default
- Slightly visible border (#1a1a1a) to keep UI structure without
  the borderless pure-black look losing all separation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@nox-0x nox-0x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean theme alignment with VSCode Pitch Black — the color values are consistent and the diff is straightforward. No functional concerns. LGTM.

@aterrylu
aterrylu merged commit 3c00fb1 into main Mar 8, 2026
1 check passed
@aterrylu
aterrylu deleted the terry/void-pitch-black branch March 8, 2026 08:26
aterrylu added a commit that referenced this pull request Jun 6, 2026
…/6) (#183)

Moves the macOS Desktop build into CI as a universal2 artifact — one DMG that
runs on Apple Silicon AND Intel — replacing the hand-built, never-CI-validated
local DMG. This is the structural fix for "ship → user finds it broken": the
DMG now can't reach a release without passing the bundle smoke test + native
Intel validation.

## Universal binary (mechanism proven locally before writing CI)

- `bundle-node.sh BUNDLE_NODE_UNIVERSAL=1` → fetch both arch Node binaries,
  lipo into one universal2 `node`. Validated: 256M fat binary, runs natively.
- `stage-universal-server.sh` → lipo the native `.node` modules from the two
  arch server bundles (built on separate CI runners) into fat binaries under
  the arm64 filenames the bundled JS references. dlopen() picks the right slice
  at runtime regardless of filename. Validated: real impit arm64+x64 lipo'd and
  loaded under BOTH arches.
- `smoke-test-bundle.sh` SMOKE_EXPECT_UNIVERSAL=1 → asserts every bundled
  `.node` + the Node binary contain both x86_64 and arm64 slices.

## release.yml (rewritten)

Four stages:
1. build-server (matrix: darwin/linux × arm64/x64) — 4 tarballs for install.sh;
   the two darwin bundles also feed the DMG's native-module lipo.
2. build-dmg (macos-14) — stage universal resources → smoke test (HARD GATE) →
   electron-builder universal DMG/ZIP/blockmap → validate-dmg via CDP
   (continue-on-error for now: headless-runner behavior is the one unknown).
3. validate-intel (macos-15-intel, HARD GATE) — mount the DMG on REAL x64
   hardware, run the smoke test natively, proving the x64 slice executes.
4. release — assemble tarballs + DMG + ZIP + blockmap + latest-mac.yml +
   SHA256SUMS; GitHub Release body = the CHANGELOG section (release-notes.ts).

## electron-builder.yml

universal target + zip (Squirrel.Mac needs it) + github publish config (so
latest-mac.yml is generated for electron-updater in PR #5). Signing stays off
— PR #4 flips identity + notarize with the Apple key.

## Local builds unchanged

build-dmg.sh now passes `--arm64`/`--x64` to keep local builds single-arch +
fast. Validated: local DMG builds AND passes the full validate-dmg.sh end-to-end
(Welcome cards, Try-It-Out, auto-auth, first-run UX, Dispatcher badge).

## Validated locally

- universal Node lipo ✓ · stage-universal-server lipo + cross-arch load ✓
- actionlint clean on all 3 workflows ✓ · all YAML parses ✓
- `make check` 353/353 ✓ · `biome check packages/` clean ✓
- local single-arch DMG build + full CDP validation ✓ (no regression)

CI iteration expected for: the universal CI build, the Intel native job, and
whether validate-dmg runs headless. Babysitting CI.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants