fix: polish — auth bypass, port mismatch, unread indicator - #59
Merged
Conversation
From /polish review of PRs #54-58: Security: - Auth bypass restricted to POST only on /api/hooks/:id (GET endpoints for status/notifications remain behind auth) Bug fix: - Port default in buildEnv() changed from 3100 to 3000 to match server default — hooks were silently posting to wrong port UX: - Unread indicator: "3 · 2m" (count in red + time) instead of confusing blue dot that looked like UI noise - markNotificationsRead only clears badge on server success (prevents flickering badge when server is down) Cleanup: - Remove "use client" directive (Vite project, not Next.js) - Biome format fixes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retroactive /polish review of PRs #54-58. Fixes a security issue, a silent bug, and UX improvements.
Security
/api/hookswere unauthenticated, leaking session data. Now onlyPOST /api/hooks/:id(the curl relay from PTY) bypasses auth.Bug fix
buildEnv()defaulted to port 3100 but the server defaults to 3000. Hook relay was silently posting to the wrong port. Fixed to 3000.UX
3 · 2m(count in red + time) replaces the confusing blue dotCleanup
"use client"directive (Vite, not Next.js)🤖 Generated with Claude Code