fix: focus terminal on sidebar session click - #66
Merged
Conversation
Sidebar session rows have tabIndex={0}, so clicking them captures
browser focus on the row's <div>. The terminal's useEffect focus
call fires async but gets swallowed by the still-focused sidebar.
Fix: blur the active element after switchPane() in all click handlers
(ungrouped sessions, group members, group headers). This releases
focus so useTerminal's isActive effect can grab it for xterm.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar click now blurs the row so terminal captures focus immediately. No more clicking the terminal after switching sessions.