fix: non-permission notifications no longer reset status to idle - #80
Merged
Conversation
Notification events with types other than permission_prompt (progress, info, etc.) were resetting agent status to "idle" during active work, causing the spinner to briefly show a green checkmark. Now only permission_prompt notifications change status to needs_input; other notifications leave the current status unchanged. Added debug logging for warning-producing status transitions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nox-0x
approved these changes
Mar 26, 2026
nox-0x
left a comment
nox-0x
left a comment
Collaborator
There was a problem hiding this comment.
Clean, well-scoped fix. Returning {} from deriveStatus for non-permission notifications correctly short-circuits the if (statusUpdate.status) guard so no state write occurs — exactly the right no-op semantics. Test update is solid: sets "working" first, then confirms the notification leaves it unchanged. Debug logging is a nice bonus, scoped appropriately to warning-producing transitions only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #79. Non-permission
Notificationevents (progress, info, idle_prompt) were resetting agent status to"idle"during active work. This caused:Now only
permission_promptnotifications change status toneeds_input. All other notification types leave the current status unchanged.Also added debug logging for transitions to warning-producing statuses (
needs_input,error) to help diagnose future issues.Test plan
🤖 Generated with Claude Code