fix: mermaid preview rendering + useShallow infinite loop - #91
Merged
Conversation
Mermaid diagrams in markdown preview were silently failing: - mermaid.render() had no .catch() — errors swallowed silently - useId() caused ID collisions in StrictMode double-renders - react-markdown v10 passes children as React nodes, not strings Also fixes infinite re-render loop (React error #185) from perf PR: - useSidebarActions() selector returned new {} on every store update without useShallow, causing maximum update depth exceeded Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSidebarActions()missinguseShallowProblem
mermaid.render()had no.catch(),useId()caused StrictMode ID collisions, and react-markdown v10 passes children as React nodes not stringsuseSidebarActions()selector that returned a new{}on every store update withoutuseShallow, causing infinite re-renders (React error chore(release): version packages #185 on page load)Changes
.catch()to mermaid.renderPreviewPane.tsx,PreviewPage.tsxuseShallowtouseSidebarActionsSidebar.tsxTest plan
🤖 Generated with Claude Code