fix: terminal auto-focus, unread auto-clear, projects collapsed - #93
Merged
Conversation
Terminal focus: - Global terminal registry + focusTerminal() called directly from sidebar clicks - rAF polling waits until terminal container is visible (offsetParent check) - onMouseDown preventDefault on all sidebar buttons prevents browser focus steal - Cancels pending focus poll on rapid session switches Unread notifications: - Separate effect watches notificationCounts for active session - Auto-clears within one poll cycle, even for notifications arriving while in session - Group header/member clicks also clear synchronously Projects section: - Starts collapsed by default, no auto-expand on session switches - Removed unused activePane/sessions props from ProjectItem Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
isActivetransitions, not new notifications)Solution
Terminal focus: Global
terminalRegistryMap lets sidebar callfocusTerminal(sessionId)directly from click handlers. Uses rAF polling (up to 10 frames) withoffsetParentcheck to wait until the terminal container is visible before calling.focus().onMouseDown={(e) => e.preventDefault()}on all sidebar buttons prevents browser from stealing focus.Unread clear: Separate
useEffectwatchesnotificationCounts[sessionId]— fires whenever the count changes while the session is active, not just onisActivetransitions.Projects: Removed
hasActiveSessionauto-expand logic and unusedactivePane/sessionsprops fromProjectItem.Test plan
/polish— all three review agents run, findings addressed🤖 Generated with Claude Code