fix(ci): stop committing package.json/package-lock.json version bumps back to the repo - #159
Merged
Merged
Conversation
… back to the repo @semantic-release/git committed the npm-bumped package.json/package-lock.json back to main on every release (no PR, but still a committed version file). Explicit preference across every tap repo: no committed version file, ever. npm publish still gets the correct version — @semantic-release/npm sets it in this CI checkout before publishing regardless of whether anything commits it back; only the repo's own committed package.json now lags the last manually-set value instead of tracking every release.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe semantic-release configuration now documents ephemeral npm versioning and retains npm provenance publishing. It removes the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
athal7
added a commit
that referenced
this pull request
Aug 10, 2026
…se (#160) release-please was added in #156 alongside the existing semantic-release setup (ci.yml) — both would trigger on push to main, double-releasing or conflicting. This repo already has a working, just-fixed (#159, no committed version file) semantic-release pipeline; it doesn't need a second release mechanism. Removing the release-please addition to leave exactly one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@semantic-release/git committed the npm-bumped package.json/package-lock.json back to main on every release (no PR, but still a committed version file). Explicit preference across every tap repo: no committed version file, ever. npm publish still gets the correct version — @semantic-release/npm sets it in this CI checkout before publishing regardless of whether anything commits it back; only the repo's own committed package.json now lags the last manually-set value instead of tracking every release.