Fix duplicate LSP server creation due to race condition#496
Merged
mehmetozguldev merged 1 commit intoJan 3, 2026
Merged
Conversation
- Move server tracking before backend invocation to prevent race condition - Add error handling to maintain consistency if backend call fails - Ensures only one LSP server instance is created per workspace/language - Fixes issue where multiple simultaneous calls would bypass deduplication
mehmetozguldev
self-requested a review
January 3, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The LSP system was creating duplicate server instances when multiple calls to
startForFileoccurred simultaneously. This resulted in two LSP server processes being spawned for the same workspace/language combination.Root Cause
The server tracking key was added to the
activeLanguageServersSet after the async backend call completed, creating a race condition window where multiple concurrent calls could all see an empty Set and proceed to create duplicate servers.Solution
Changes
src/features/editor/lsp/lsp-client.ts: Reordered operations to add server key to Set before invoking backend, added try-catch for cleanup on failuresrc-tauri/src/lsp/manager.rs: Removed debug instrumentation (cleanup only)Testing
Verified with instrumented logs that:
Impact