Skip to content

Do not override php version in composer for php 8.0 testing#268

Merged
mvorisek merged 2 commits intodevelopfrom
no_php8_ver_override
Oct 15, 2020
Merged

Do not override php version in composer for php 8.0 testing#268
mvorisek merged 2 commits intodevelopfrom
no_php8_ver_override

Conversation

@mvorisek
Copy link
Member

@mvorisek mvorisek commented Aug 25, 2020

finish after phpspec/prophecy#495 and phpspec/prophecy#491

merge once tests are passing, check if simillar change is possbile for other repos

@mvorisek mvorisek added waitingForAnotherPR PHP8.0+ Requires PHP 8.0 or higher labels Aug 25, 2020
@mvorisek mvorisek marked this pull request as ready for review August 26, 2020 10:47
@mvorisek mvorisek force-pushed the no_php8_ver_override branch from dc51c58 to cd3143d Compare August 26, 2020 19:01
@mvorisek mvorisek closed this Oct 14, 2020
@mvorisek mvorisek reopened this Oct 14, 2020
@mvorisek
Copy link
Member Author

RTM, all packages are installable for php 8.0 now

@mvorisek mvorisek force-pushed the no_php8_ver_override branch from cd3143d to 8482bf9 Compare October 15, 2020 10:30
Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit e37849d into develop Oct 15, 2020
@mvorisek mvorisek deleted the no_php8_ver_override branch October 15, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP8.0+ Requires PHP 8.0 or higher RTM

Development

Successfully merging this pull request may close these issues.

2 participants