Skip to content

Conversation

@offa
Copy link
Contributor

@offa offa commented Sep 30, 2019

A first attempt to make the kerberos dependency optional (#349).

# default - no kerberos dependency
> pip install atlassian-python-api

# kerberos dependency included
> pip install "atlassian-python-api[kerberos]"

Open issues

  • How to handle requirements.txt (separate file)?
  • Update documentation (especially how to install extra dependencies).
  • Are CI tests for both version available?
  • Calling kerberos authentication without supplying the dependency should cause a failure.
  • How to get both use cases into pip? (Or does it already work via setup.py?)

@gonchik gonchik closed this Oct 1, 2019
@gonchik gonchik reopened this Oct 1, 2019
@gonchik gonchik merged commit 4f8fe7c into atlassian-api:master Oct 1, 2019
@offa offa deleted the kerberos_optional branch October 1, 2019 15:15
@offa offa mentioned this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants