Skip to content

Conversation

@offa
Copy link
Contributor

@offa offa commented Oct 1, 2019

Some open issues mentioned in #353 fixed:

  1. Exception if kerberos is used but not installed
  2. Tox config updated to include the extra dependency
  3. Note added to the documentation. Is this enough or is a full pip call more suitable?

@offa
Copy link
Contributor Author

offa commented Oct 1, 2019

The installation of optional dependencies through the pypi package doesn't work.

> pip install atlassian-python-api[kerberos]

Results in No matches found.

It works from source and the installed package contains some sort of dependency information (requires.txt) 🤔 :

requests
six
oauthlib
requests_oauthlib

[kerberos]

[kerberos:platform_system != "Windows"]
kerberos

[kerberos:platform_system == "Windows"]
kerberos-sspi

@offa
Copy link
Contributor Author

offa commented Oct 1, 2019

Well … quotes to the trick:

pip install "atlassian-python-api[kerberos]"

And it works! 👍

@offa
Copy link
Contributor Author

offa commented Oct 3, 2019

There's just on minor issue left: How to handle the requirements.txt?

  1. Move kerberos to a seperate one which sources the common file
  2. Keep all dependencies in one file as it's at the moment

Are there any preferences?

@gonchik
Copy link
Member

gonchik commented Oct 3, 2019

I think the better way is keep in one file, as we can number of dependency.

@offa
Copy link
Contributor Author

offa commented Oct 3, 2019

So, then the PR is ready from my side.

@gonchik gonchik merged commit 387afc4 into atlassian-api:master Oct 9, 2019
@gonchik
Copy link
Member

gonchik commented Oct 9, 2019

Thank you :)

@offa offa deleted the for_kerberos branch October 10, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants