Fix formatPlainTime locale handling and improve test coverage - #46
Merged
Conversation
zac1st1k
force-pushed
the
bugfix/fix-format-plain-time-nan-error
branch
from
July 20, 2026 03:58
53f73f6 to
077471a
Compare
zac1st1k
force-pushed
the
bugfix/fix-format-plain-time-nan-error
branch
from
July 20, 2026 04:13
077471a to
ab2c858
Compare
zac1st1k
commented
Jul 20, 2026
| } | ||
|
|
||
| export function formatPlainTime(date = new Date(), timeZone = getTimeZone()) { | ||
| const timeZonedDate = new Date(date.toLocaleString(undefined, { timeZone })); |
Collaborator
Author
There was a problem hiding this comment.
This function is not pure when the parameter is undefined. The returned date string can depend on browser user settings.
jdyAt
approved these changes
Jul 20, 2026
zac1st1k
changed the title
formatPlainTime locale handling and improve test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatPlainTimereturning"NaN:NaN:NaN"under dd/mm/yyyy runtime locales (e.g.en-GB) when the day is > 12, by pinning the locale used in itstoLocaleStringround-trip toen-US.en-USanden-GB(test:en-US/test:en-GB, both invoked bynpm test) to catch this class of locale regression going forward.package.json#files(drop.npmignore), and verify thenpm packoutput against that whitelist inindex.dist.test.ts.Test plan
npm run test:en-USnpm run test:en-GBnpm run lint