This repository was archived by the owner on Jan 13, 2021. It is now read-only.
Correct capitalisation of HorizontalPodAutoscaler kind#320
Merged
Conversation
nilebox
approved these changes
Sep 24, 2018
nilebox
reviewed
Sep 24, 2018
| core_v1.SchemeGroupVersion.WithKind("ServiceAccount"): core_v1inf.NewServiceAccountInformer, | ||
| apps_v1.SchemeGroupVersion.WithKind("Deployment"): apps_v1inf.NewDeploymentInformer, | ||
| autoscaling_v2b1.SchemeGroupVersion.WithKind("HorizontalPodAutoScaler"): autoscaling_v2b1inf.NewHorizontalPodAutoscalerInformer, | ||
| autoscaling_v2b1.SchemeGroupVersion.WithKind("HorizontalPodAutoscaler"): autoscaling_v2b1inf.NewHorizontalPodAutoscalerInformer, |
Contributor
There was a problem hiding this comment.
Should this be catched by integration tests?
IIRC they don't run in Travis anymore, but probably on the local machine there is still a way?
Contributor
Author
There was a problem hiding this comment.
We don't have integration tests for kube compute yet (that is coming soon). However I had successfully deployed on Playground prior to this change so I'm not entirely sure how that didn't catc hit.
Contributor
There was a problem hiding this comment.
You should be able to run Smith's integration tests locally or against a cluster.
ash2k
approved these changes
Sep 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix capitalisation of HorizontalPodAutoscaler kind so the informer for HPAs is correctly registered.