Skip to content
This repository was archived by the owner on Jan 13, 2021. It is now read-only.

Correct capitalisation of HorizontalPodAutoscaler kind #320

Merged
mcoot merged 1 commit into from
Sep 24, 2018
Merged

Correct capitalisation of HorizontalPodAutoscaler kind #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/smith/app/bundle_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ func (c *BundleControllerConstructor) resourceInformers(config *ctrl.Config, cct
core_v1.SchemeGroupVersion.WithKind("Secret"): core_v1inf.NewSecretInformer,
core_v1.SchemeGroupVersion.WithKind("ServiceAccount"): core_v1inf.NewServiceAccountInformer,
apps_v1.SchemeGroupVersion.WithKind("Deployment"): apps_v1inf.NewDeploymentInformer,
autoscaling_v2b1.SchemeGroupVersion.WithKind("HorizontalPodAutoScaler"): autoscaling_v2b1inf.NewHorizontalPodAutoscalerInformer,
autoscaling_v2b1.SchemeGroupVersion.WithKind("HorizontalPodAutoscaler"): autoscaling_v2b1inf.NewHorizontalPodAutoscalerInformer,

@nilebox nilebox Sep 24, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be catched by integration tests?
IIRC they don't run in Travis anymore, but probably on the local machine there is still a way?

@mcoot mcoot Sep 24, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have integration tests for kube compute yet (that is coming soon). However I had successfully deployed on Playground prior to this change so I'm not entirely sure how that didn't catc hit.

@ash2k ash2k Sep 24, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to run Smith's integration tests locally or against a cluster.

}
infs := make(map[schema.GroupVersionKind]cache.SharedIndexInformer, len(coreInfs)+2)
for gvk, coreInf := range coreInfs {
Expand Down