feat(ato-cli): best-effort Windows root taskkill for import preview - #315
Merged
Conversation
Koh0920
force-pushed
the
feat/import-workspace-cleanup-guard
branch
from
May 26, 2026 19:19
a59403c to
4567d73
Compare
Koh0920
force-pushed
the
feat/import-preview-windows-process-tree
branch
from
May 26, 2026 19:19
cf2f0a9 to
b6c3b88
Compare
Koh0920
force-pushed
the
feat/import-workspace-cleanup-guard
branch
from
May 26, 2026 19:25
4567d73 to
0ffa94c
Compare
Koh0920
force-pushed
the
feat/import-preview-windows-process-tree
branch
from
May 26, 2026 19:25
b6c3b88 to
5b90004
Compare
Koh0920
force-pushed
the
feat/import-workspace-cleanup-guard
branch
from
May 27, 2026 01:46
0ffa94c to
c4428f5
Compare
Koh0920
force-pushed
the
feat/import-preview-windows-process-tree
branch
from
May 27, 2026 02:02
5b90004 to
7e51ba5
Compare
Contributor
Author
|
Narrowed the PR scope/title/body to match the current implementation: this is now explicitly a best-effort Windows root |
Contributor
Author
|
Keeping this PR in draft. The remaining gate is real Windows runtime smoke; the repository currently has no existing workflow that performs this runtime validation, and the available CI here is limited to Linux/macOS plus Windows packaging. Remaining smoke on a Windows host:
Once those steps pass, this PR can move from draft to ready for review. |
…ndows-process-tree
Koh0920
marked this pull request as ready for review
May 30, 2026 07:28
Koh0920
added a commit
that referenced
this pull request
Jul 1, 2026
…ess-tree feat(ato-cli): best-effort Windows root taskkill for import preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 6 of #306. This PR is intentionally narrow: it adds a best-effort Windows root taskkill path for import preview session stop.
What this PR does:
ato_run_pidis alive and its start time still matches, Windows stop usestaskkill /PID <root> /Tto terminate that root treeWhat this PR does not do yet:
ATO_RUN_SESSION_IDValidation note
This remains a draft until Windows runtime smoke is collected. Minimum validation still needed:
ato import --run --keep-alive --emit-jsonstarts a child server on Windowsato stop <run_session_id>removes the live root + child treeOut of scope
Tests
Part of #306.