This repository was archived by the owner on Jul 23, 2019. It is now read-only.
Add rust-toolchain file to specify required Rust version#69
Merged
nathansobo merged 1 commit intomasterfrom Apr 27, 2018
Merged
Add rust-toolchain file to specify required Rust version#69nathansobo merged 1 commit intomasterfrom
nathansobo merged 1 commit intomasterfrom
Conversation
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking out the branch for #67, I ran into an issue compiling the project. @as-cii pointed out that Xray now depends on Rust 1.27 nightly. This pull request adds a
rust-toolchainfile to make that dependency explicit. With this change in place, running./script/buildwill automatically install the nightly release if it's not already present, and it will then use that release to build the project.It's possible to specify
nightlyas the version, but since nightly is a moving target, it seems useful to me to pin to a specific nightly build, so I've pinned it to the latest nightly build:nightly-2018-04-27. If we make a change that requires a newer version, we would then updaterust-toolchainto make that dependency explicit.