This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Store represented directory paths directly on AtomWindow in main process#13768
Merged
nathansobo merged 1 commit intomasterfrom Feb 7, 2017
Merged
Store represented directory paths directly on AtomWindow in main process#13768nathansobo merged 1 commit intomasterfrom
nathansobo merged 1 commit intomasterfrom
Conversation
Fixes #13729 Previously, when adding a window, we were unable to read its current project paths out of the hash of the URL during window initialization because the window still considered itself to be loading. Rather than fixing this issue, we decided to completely eliminate the sharing of state between processes in the window.location and instead switch to cached synchronous RPC for the loadSettings and a dedicated RPC-based mechanism for the project paths.
Contributor
|
taking a 👀 |
Contributor
I am still able to repro the issue in #13729. |
Contributor
Author
|
@ungb strange. I checked again and this is working. It seems like the steps pictured in your animation are somewhat different than the original reproduction steps for the issue. I wonder if there's another issue involved. Here's what works for me:
|
Contributor
Author
|
Sorry, I had associated this PR with the wrong issue out of confusion. I should have referenced fixing #13761. I've updated the PR body accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #13761
Previously, when adding a window, we were unable to read its current project paths out of the hash of the URL during window initialization because the window still considered itself to be loading. Rather than fixing this issue, we decided to completely eliminate the sharing of state between processes in the window.location and instead switch to cached synchronous RPC for the loadSettings and a dedicated RPC-based mechanism for the project paths.
🍐 'd with @maxbrunsfeld