This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
a5889ae to
9799b2a
Compare
9799b2a to
42676fc
Compare
Gruntfile.js
Outdated
| * decaffeinate suggestions: | ||
| * DS102: Remove unnecessary code created because of implicit returns | ||
| * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md | ||
| */ |
42676fc to
a255ad1
Compare
maxbrunsfeld
approved these changes
Sep 11, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
libfrom.gitignoreaslibis now the source files (no build steps!)Notes:
event-kitnow requires a modern version of Node/Electron. Let me know if we need this compatible with older environments (e.g. browsers) and I can add a build step through babel.disposed = falsefrom the respective prototype to the constructors for each instance. This feels like more idiomatic js, but if this was placed on the prototype as an optimization, please let me know....instead of a ternary handling the null case, this short circuits on the falsey case, as
this.handlersByEventNameshould only ever be a nullable object. Happy to tighten this up if desired.Test Plan:
npm testand linked this package with Atom and Nuclide and smoke tested superficial features