Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ npm-debug.log
*.swp
.coffee
api.json
dist
package-lock.json
3 changes: 1 addition & 2 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
spec
script
src
*.coffee
lib
.npmignore
.DS_Store
npm-debug.log
.travis.yml
.pairs
.coffee
9 changes: 6 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"name": "event-kit",
"version": "2.5.1",
"description": "Simple library for implementing and consuming evented APIs",
"main": "./lib/event-kit",
"main": "./dist/event-kit",
"scripts": {
"prepublish": "grunt shell:update-atomdoc atomdoc",
"test": "grunt test"
"prepublish": "babel lib --out-dir dist --presets @babel/env && grunt shell:update-atomdoc atomdoc",
"test": "jasmine-focused --captureExceptions --forceexit spec"
},
"repository": {
"type": "git",
Expand All @@ -17,6 +17,9 @@
"license": "MIT",
"dependencies": {},
"devDependencies": {
"@babel/cli": "^7.1.2",
"@babel/core": "^7.1.2",
"@babel/preset-env": "^7.1.0",
"grunt": "^0.4.1",
"grunt-atomdoc": "^1.0.0",
"grunt-cli": "^0.1.8",
Expand Down
4 changes: 2 additions & 2 deletions spec/composite-disposable-spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const CompositeDisposable = require("../lib/composite-disposable")
const Disposable = require("../lib/disposable")
const CompositeDisposable = require("../dist/composite-disposable")
const Disposable = require("../dist/disposable")

describe("CompositeDisposable", function() {
let disposable1, disposable2, disposable3
Expand Down
21 changes: 18 additions & 3 deletions spec/disposable-spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const Disposable = require("../lib/disposable")
const Disposable = require("../dist/disposable")

describe("Disposable", function() {
it("does not try to execute disposalAction when it is not a function", function() {
Expand All @@ -23,7 +23,21 @@ describe("Disposable", function() {
expect(disposalAction.callCount).toBe(1)
})

describe(".isDisposable(object)", () =>
it('can be extended by ES5-style classes', () => {
function MyDisposable () {
// super
Disposable.apply(this, arguments)
}

MyDisposable.prototype = new Disposable()

let actionCalled = false
const disposable = new MyDisposable(() => { actionCalled = true })
disposable.dispose()
expect(actionCalled).toBe(true)
})

describe(".isDisposable(object)", () => {
it("true if the object implements the ::dispose function", function() {
expect(Disposable.isDisposable(new Disposable(function() {}))).toBe(true)
expect(Disposable.isDisposable({ dispose() {} })).toBe(true)
Expand All @@ -32,5 +46,6 @@ describe("Disposable", function() {
expect(Disposable.isDisposable(undefined)).toBe(false)
expect(Disposable.isDisposable({ foo() {} })).toBe(false)
expect(Disposable.isDisposable({ dispose: 1 })).toBe(false)
}))
})
})
})
2 changes: 1 addition & 1 deletion spec/emitter-spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const Emitter = require("../lib/emitter")
const Emitter = require("../dist/emitter")

describe("Emitter", function() {
it("invokes the observer when the named event is emitted until disposed", function() {
Expand Down