New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the StagingView to React #1424

Merged
merged 26 commits into from Apr 30, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Apr 27, 2018

The final part of #381.

  • Remove the EtchWrapper
  • Tests green
  • Try it out live

smashwilson and others added some commits Apr 27, 2018

Blam
Co-Authored-By: Katrina Uychaco <kuychaco@github.com>
Co-Authored-By: Tilde Ann Thurium <annthurium@github.com>

@smashwilson smashwilson merged commit ac72922 into master Apr 30, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/the-final-react branch Apr 30, 2018

@smashwilson

This comment has been minimized.

Member

smashwilson commented Apr 30, 2018

Our tests are green and everything seemed to be well-behaved while I was trying it live, but there is a fair amount of risk of this regressing something. I'm merging now so we have a decent chunk of time to find regressions before the next ship 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment