Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IssueishPaneItemView #1551

Merged
merged 13 commits into from Jun 26, 2018

Conversation

Projects
3 participants
@simurai
Copy link
Member

simurai commented Jun 25, 2018

Description of the Change

This refactors IssueishPaneItemView. a.k.a. "PR details opened in a center pane" view.

Benefits

  1. Uses our naming convention.
  2. Cleans up _global.less #1251
  3. Makes it more extendable for future changes.

Possible Drawbacks

Might not actually make it more extendable.

Applicable Issues

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 25, 2018

Coverage Status

Coverage decreased (-0.02%) to 71.334% when pulling d577910 on sm-refactor-issueishpaneitem into 1e19579 on master.

@simurai simurai changed the title [WIP] Refactor IssueishPaneItemView Refactor IssueishPaneItemView Jun 26, 2018

@simurai

This comment has been minimized.

Copy link
Member Author

simurai commented Jun 26, 2018

I'll merge this before @smashwilson is probably gonna edit some of the files. Hopefully nothing broke. 😇

@simurai simurai merged commit 150ef5e into master Jun 26, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-refactor-issueishpaneitem branch Jun 26, 2018

@smashwilson smashwilson added the rfc-002 label Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.