Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Backportable keymap changes #1847
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
Restore MultiFilePatch navigation keybindings unadorned by
I've also separated the
Another alternative that we talked about was showing a notification the first time that you try to use one of the deprecated keystrokes (and letting the keystroke go through to the editor normally). I think we should do that as part of the diff editability work, personally.
This keeps our keybinding changes from breaking users' muscle memory for another few releases.
If anyone on macOS learned the ctrl- keystrokes for some reason, those will be broken by this.
It also gives us a lot of redundancy in our keymap, which hurts maintainability. Hopefully this is just a temporary thing.
Related to #1820.
Out of scope for the moment.
Our existing test suite should catch any regressions here.
The flight manual already references unadorned keystrokes, which is a good reason to backport this. I've also already filed atom/flight-manual.atom.io#504 to update it to use the
User Experience Research (Optional)
@@ Coverage Diff @@ ## master #1847 +/- ## ========================================== + Coverage 90.85% 90.91% +0.05% ========================================== Files 195 195 Lines 10727 10727 Branches 1570 1570 ========================================== + Hits 9746 9752 +6 + Misses 981 975 -6