-
Notifications
You must be signed in to change notification settings - Fork 391
v0.24.0-1 QA Review #1870
Comments
Holding the release until we can fix #1868. |
Not sure if this is the right place to report QA-related feedback, but here are some some issues and general suggestions. Let me know if you'd like me to split these into separate issues. 😇 Pull request tabs' titles have selectable textBreaks the feeling of them being buttons. Spacing before
|
@robertrossmann Oh wow, thanks! This is super thorough and helpful.
You're right, I think we'd prefer to track these as separate issues rather than grouping them all here. You've already taken the trouble to write it all up, though, so I can handle the splitting 😄 These QA issues are part of the way we ship - they're intended to be a final, simple smoke test to ensure that all of the bugs and features we think we're releasing still actually work once we tag a release and include it in a full Atom build as a bundled module distributed within Atom's startup snapshot. Historically, we've had a few pretty bad problems that almost made it to release because they were hidden by our usual testing M.O. of installing the package non-bundled from git, and linking it in dev mode. With that in mind, I'll hold up 0.24.0 tag for the graphical glitches you've found, but the others we'll keep as issues for a future sprint to keep our release scope from creeping. |
Thank you @smashwilson for the explanation - in the future, I'll open up separate issues for all of these. ❤️ |
Okay, I think I got them all; the "large diff" gate issue was already captured here: #1759.
✨ 👍 |
Next release candidate QA checklist: #1879 |
Changes to verify
pullRequest.headRepository
is nullOther changes in this release
The text was updated successfully, but these errors were encountered: