New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove specs testing non-existent meta.outside-tag scopes #173

Merged
merged 1 commit into from Sep 23, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Sep 23, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Removes meta.outside-tag scope specs, as that pattern was removed in #172. The current patterns should have no chance of locking up.

Alternate Designs

None.

Benefits

Code maintenance.

Possible Drawbacks

Future patterns that lock up in the scenarios tested. However, I find that unlikely.

Applicable Issues

atom/first-mate#100
atom/first-mate#101

@50Wliu 50Wliu merged commit 4b85314 into master Sep 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-rm-unused-specs branch Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment