This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Use createDOMPurify differently#188
Merged
smashwilson merged 3 commits intomasterfrom Mar 22, 2018
Merged
Conversation
Contributor
Author
|
@hansonw for future reference: I think DOMPurify does some require-time environment inference stuff that gets confused when we're building the v8 snapshot within the Atom build. Of course, we don't snapshot for our tests, so they were happily green... I've fixed it here by changing it to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating DOMPurify to use the node API.