Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Use PackageCard in Available Updates panel - #540

Closed
mgarciaisaia wants to merge 1 commit into
atom:masterfrom
mgarciaisaia:update-view-package-cards
Closed

Use PackageCard in Available Updates panel#540
mgarciaisaia wants to merge 1 commit into
atom:masterfrom
mgarciaisaia:update-view-package-cards

Conversation

@mgarciaisaia

Copy link
Copy Markdown
Contributor

PackageCards show Update buttons whenever there are new versions (even in other panels).

update-cards

They cards aren't half-wided, but they work better than the previous view.

Fixes #499
Fixes #529
Supersedes #539

PackageCards show Update buttons whenever there are new versions.
They cards aren't half-wided, but they work better than the previous view.

Fixes atom#499
Fixes atom#529
@mgarciaisaia
mgarciaisaia force-pushed the update-view-package-cards branch from 7356259 to f53c592 Compare June 10, 2015 13:33
@mnquintana

Copy link
Copy Markdown
Contributor

Awesome, thanks so much for this! I did find a few issues though:

  • Package card doesn't change state when clicking the uninstall button
    • With disabled packages, the package card doesn't change state at all
    • Uninstalling enabled packages leaves a package card with an update button
      • Clicking that update button re-installs the package and updates it

Do you think you could take a look at these cases (and add specs for them)?

@mgarciaisaia

Copy link
Copy Markdown
Contributor Author

I sure can try.

May those be PackageCard's issues - ie, a separate issue?

I'll try to review this later.

@benogle

benogle commented Jul 1, 2015

Copy link
Copy Markdown
Contributor

I love this idea. I think we can fix the issues @mnquintana pointed out in other PRs, then merge this.

@benogle

benogle commented Jul 7, 2015

Copy link
Copy Markdown
Contributor

Merged in #572

@benogle benogle closed this Jul 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants