Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@nathansobo
Copy link
Contributor

Closes #751

This PR applies some minor cleanup to #751. Thanks to @kumarharsh for the contribution!

@kumarharsh: In case you're interested:

  • I moved your test and went ahead and combined two tests into one, which tested the basic behavior as well as parent directory expansion.
  • In the future, we prefer commit messages and PR titles to be phrased in the imperative voice. "Add option" rather than "Added option". That said, I'd rather have the contribution than worry too much about this so I'll go ahead and merge the commit as-is.

Thanks again!!

Kumar Harsh and others added 3 commits February 27, 2016 21:06
nathansobo pushed a commit that referenced this pull request Mar 4, 2016
Add option to auto-reveal tree view entries when they become the active pane item
@nathansobo nathansobo merged commit 55204b3 into master Mar 4, 2016
@nathansobo nathansobo deleted the ns-auto-reveal branch March 4, 2016 22:14
@kumarharsh
Copy link
Contributor

@nathansobo Thanks :) and yes, sorry about that commit message, point taken!

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Sep 28, 2016

Closes #426?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants