This repository was archived by the owner on Aug 12, 2019. It is now read-only.
Merged
Conversation
added 4 commits
January 5, 2017 17:37
This ensures we don't create multiple copies of the welcome panes on refresh and that deserialization works correctly.
30 tasks
added 7 commits
January 6, 2017 10:12
|
@nathansobo Just finished testing various things on the welcome package with your changes. Everything looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty substantial rework of this package that does the following:
Reportersingleton and replace it with an instance variable on the main module.I did pretty extensive manual testing but it would be great if you could give this a spin @ungb. One known issue is that text editors for the init script, style sheet, config, and snippets aren't opening in the left pane. This is actually an issue in atom/atom and atom/snippets and I plan to fix it there.