Skip to content
This repository was archived by the owner on Aug 12, 2019. It is now read-only.

Comments

Remove use of jQuery and modernize#56

Merged
nathansobo merged 11 commits intomasterfrom
ns-remove-jquery
Jan 9, 2017
Merged

Remove use of jQuery and modernize#56
nathansobo merged 11 commits intomasterfrom
ns-remove-jquery

Conversation

@nathansobo
Copy link
Contributor

@nathansobo nathansobo commented Jan 6, 2017

This is a pretty substantial rework of this package that does the following:

  • Convert CoffeeScript to JS
  • Use Etch rather than SpacePen for all views.
  • Switch tests from legacy built-in infrastructure to Mocha.
  • Extract a singleton class and decouple tests from Atom's package management.
  • Eliminate Reporter singleton and replace it with an instance variable on the main module.

I did pretty extensive manual testing but it would be great if you could give this a spin @ungb. One known issue is that text editors for the init script, style sheet, config, and snippets aren't opening in the left pane. This is actually an issue in atom/atom and atom/snippets and I plan to fix it there.

Nathan Sobo added 4 commits January 5, 2017 17:37
This ensures we don't create multiple copies of the welcome panes on
refresh and that deserialization works correctly.
@nathansobo nathansobo changed the title WIP: Remove use of jQuery Remove use of jQuery and modernize Jan 6, 2017
@ungb
Copy link

ungb commented Jan 8, 2017

@nathansobo Just finished testing various things on the welcome package with your changes. Everything looks good!

@nathansobo nathansobo merged commit 7d94660 into master Jan 9, 2017
@nathansobo nathansobo deleted the ns-remove-jquery branch January 9, 2017 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants