feat: add additive provider-model insert migration family, port 337 to it - #6107
Merged
atomantic merged 1 commit intoSep 3, 2026
Merged
Conversation
…o it (atomantic#6072) New "family 7b" factory, makeAdditiveProviderInsertMigration, splices a replacement model id after a retired one on a possibly-curated models list without rewriting or dropping anything else — unlike family 7's exact-match pristine-list rewrite. runAdditiveProviderInsertMigrationTests in the shared test helper derives its fixtures from the migration's own targets table, the same convention the other migration families already use. Migration 337 (claude-sonnet-5 additive repair) is rewritten as a thin config on top of the new factory. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
atomantic
approved these changes
Sep 3, 2026
atomantic
left a comment
atomantic
left a comment
Owner
There was a problem hiding this comment.
Reviewed — change is correct, focused, and covered by tests. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeAdditiveProviderInsertMigration({ targets, label })toscripts/migrations/_lib.jsas a new "family 7b": it splices a replacement model id after a retired one on a provider'smodelslist, without rewriting or dropping anything else on a possibly-curated (user-edited) list — unlike family 7's exact-match pristine-list rewrite, which is the wrong tool when the list may have been hand-customized.runAdditiveProviderInsertMigrationTests({ migration, targets, prefix })toscripts/migrations/_testHelpers.js, following the same convention as the existing shared test helpers: fixtures are derived from the migration's owntargetstable so behavior and coverage can't drift apart.claude-sonnet-5additive repair) as a thin config wrapping the new factory, exportingTARGETSso its test file can build on the shared helper instead of hand-rolling its own fixtures.Test plan
scripts/migrations/337-claude-sonnet-5-additive.test.js— 96/96 (via the new shared helper)scripts/migrations/directory run — no new failures introduced🤖 Generated with Claude Code