fix(cos): drop the redundant eligible-provider list from PR-reviewer stage notes - #6115
Merged
Merged
Conversation
…stage notes The tool-free and sandboxed-actions stage descriptions each restated "Eligible on this install: <providers>" — the same set the stage's own provider dropdown already offers, so the copy was duplicate information that pushed the useful part of the note out of view. The notes now explain only what the dropdown cannot: for the sandboxed stage, which of the selectable providers the vendor wraps in its own OS sandbox versus which rely on the disposable worktree alone. Claude-Session: https://claude.ai/code/session_01NFdn2eiEjKVoNuNdM7dFy6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR-reviewer pipeline stage descriptions each restated "Eligible on this install:
<providers>" — the exact same set the stage's own provider dropdown already offers. That duplicated the dropdown in prose and pushed the part of the note the dropdown can't convey further down.Both notes now lead with what only they can say:
The eligible-provider computation is unchanged — it still drives the dropdown's
selectionPolicy, the isolation split, and the "no enabled AI provider can enforce this posture" warning.Test plan
client/src/components/cos/tabs/schedule/PipelineStageConfig.test.jsxupdated: the two assertions that pinned the removed copy now assert the dropdown options (which is where eligibility is actually exposed) plus that the note names no provider it shouldn't. The isolation-split assertions are untouched and still pass.cd client && npx vitest run src/components/cos— 42 files, 559 tests pass.npx biome lint --error-on-warnings src/components/cos/tabs/schedule— clean.https://claude.ai/code/session_01NFdn2eiEjKVoNuNdM7dFy6