Add Pi coding agent CLI/TUI providers and review runner - #6351
Conversation
|
Leaving this PR open after the configured three CI repair rounds. It has not been merged. The latest head is Server shard 2 and the database job passed on this head. Local validation includes 595 initial focused server tests, 316 provider/picker client tests, 219 reviewer server tests, 115 reviewer UI tests, client lint/build, and the targeted import checks. Claude reviewed at low effort; confirmed findings were addressed. The slashdo dependency is already merged: atomantic/slashdo#249. The |
Pi's provider entries carry no local-runtime/gateway marker and pin modelsArgs, so usesHarnessCatalog() now correctly includes pi-cli/ pi-tui alongside the other self-listing harnesses — the shipped-list gate test just hadn't been updated for it, which failed CI.
bf6586d to
b097914
Compare
Summary
Adds disabled Pi CLI/TUI presets, runtime installation and model discovery, and provider dispatch with positional prompt delivery and thinking-effort controls. Migration 354 adds the presets without replacing local configuration or starting provider work.
Pi is available in reviewer configuration and the slashdo review/enhancement workflows. Public no-tool review discards configured arguments and disables tools, extensions, project trust, and resource discovery. Pi does not advertise an action-review posture.
Closes #6350
Test plan
Claude reviewed both diffs at low effort. Confirmed findings were fixed; 250 server tests and 143 slashdo tests passed after those fixes. Pi isolation flags were verified against the official CLI reference.
Slashdo dependency: atomantic/slashdo#249.
CI follow-up: wired Pi into the shared reviewer model picker and deferred catalog/version parser imports. The import guard now pins the deferred boundary and restores its documented allowance for ordinary module growth; 165 focused server tests passed after that change.