This repository was archived by the owner on Nov 9, 2024. It is now read-only.
Add isVisible and isEnabled props #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwinn
reviewed
Nov 14, 2018
| } | ||
|
|
||
| if (this.isManualTrigger && isVisible === true) { | ||
| this.tip.show() |
There was a problem hiding this comment.
Per atomiks/tippyjs#230, shouldn't this be?
Suggested change
| this.tip.show() | |
| setTimeout(this.tip.show) |
Owner
Author
There was a problem hiding this comment.
I'm going to release a new tippy.js patch that changes the global click listener to use capture phase (instead of bubbling) by default. That will prevent the need to do this.
There was a problem hiding this comment.
May want to update the docs on how isVisible and showOnInit relate (or don't) to help avoid confusion down the road. Nice job on the project and thank you for all the work.
atomiks
added a commit
that referenced
this pull request
Nov 16, 2018
atomiks
added a commit
that referenced
this pull request
Nov 16, 2018
* Switch to react-testing-library * Remove PR #20 tests for now
Owner
Author
|
Switching to Not sure what was wrong, but the tests are passing now and coverage 100% |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps Tippy's
.enable(),.disable(),.show(), and.hide()methods using props.isVisiblemust be accompanied bytrigger="manual"For some reason the
isVisibletests are failing. Anyone want to take a look? Seems liketrigger="manual"causes a problem but I have no idea why.Manual dev environment tests show it working as expected