This repository was archived by the owner on Nov 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 97
Add isVisible and isEnabled props #20
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
63a9922
Add isVisible and isEnabled props
atomiks 1efe2c0
Use destructuring
atomiks 4c9c72a
Add propTypes
atomiks cd33a55
Refactor variables
atomiks 55f7700
Better getNativeTippyProps() implementation
atomiks 9119a9a
Code coverage fixes
atomiks 4dd8f6e
Add react-testing-library test versions
atomiks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,14 @@ | ||
| import React from 'react'; | ||
| import { Instance, Props } from 'tippy.js'; | ||
| import React from 'react' | ||
| import { Instance, Props } from 'tippy.js' | ||
|
|
||
| type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>> | ||
|
|
||
| export interface TippyProps extends Omit<Props, 'content'> { | ||
| content: React.ReactNode | string | ||
| children: React.ReactNode | ||
| onCreate?: (tip: Instance) => void | ||
| isVisible?: boolean | ||
| isEnabled?: boolean | ||
| } | ||
|
|
||
| export default class Tippy extends React.Component<TippyProps> {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per atomiks/tippyjs#230, shouldn't this be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to release a new
tippy.jspatch that changes the global click listener to use capture phase (instead of bubbling) by default. That will prevent the need to do this.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to update the docs on how
isVisibleandshowOnInitrelate (or don't) to help avoid confusion down the road. Nice job on the project and thank you for all the work.