Skip to content
This repository was archived by the owner on Nov 9, 2024. It is now read-only.

Conversation

@atomiks
Copy link
Owner

@atomiks atomiks commented Jun 20, 2020

@tyteen4a03 @tony

Does this fix the issue?

@tony
Copy link

tony commented Jun 20, 2020

@atomiks Trying it out now.

@tony
Copy link

tony commented Jun 20, 2020

@atomiks How do I try it without having to publish it on NPM?

yarn add atomiks/tippyjs-react#231/head

failed Building production JavaScript and CSS bundles - 8.777s

 ERROR #98124  WEBPACK

Generating JavaScript bundles failed

Can't resolve '@tippyjs/react' in ''

If you're trying to use a package make sure that '@tippyjs/react' is installed. If you're trying to use a local file make sure that the path is correct.

@atomiks
Copy link
Owner Author

atomiks commented Jun 20, 2020

Edit node_modules/@tippyjs/react/dist/tippy.umd.js + tippy.esm.js with the new code.

@tony
Copy link

tony commented Jun 20, 2020

@atomiks Sure - but note it won't be a pushed build to production - it'll be a prod build on a local machine.

But this is probably enough.

yarn add atomiks/tippyjs-react#231/head
cd node_modules/@tippyjs/react
npm install
npm run build

Back into project root, gatsby clean && gatsby build && gatsby serve

Works.

@tony
Copy link

tony commented Jun 20, 2020

Thank you @atomiks !

@atomiks
Copy link
Owner Author

atomiks commented Jun 20, 2020

Yeah it broke my docs website too and I didn't know why 😩

I also just tested it on the docs (Gatsby) and it seems to work.

@atomiks atomiks merged commit 12fe382 into master Jun 20, 2020
@atomiks atomiks deleted the fix/portal branch June 20, 2020 22:47
@tony
Copy link

tony commented Jun 20, 2020

@atomiks Gatsby seemed to bury the error for me.

next.js seemed to give a nicer traceback, interestingly

have a good weekend!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants