fix: register legacy IBC gov proposal content types in atomone gov fork#356
Merged
Conversation
The v4 mainnet upgrade failed during the gov proposal migration with: failed to migrate gov proposals: failed to get proposal value: no concrete type registered for type URL /ibc.core.client.v1.ClientUpdateProposal against interface *v1beta1.Content The AtomOne gov module fork defines its own Content interface (atomone.gov.v1beta1.Content), and MsgExecLegacyContent unpacks its content Any against it. ibc-go registers ClientUpdateProposal and UpgradeProposal against the SDK's gov Content interface, but not against ours, so a historical mainnet proposal (#20) wrapping a ClientUpdateProposal failed to unpack during migration. Register both legacy IBC 02-client proposal content types against the AtomOne Content interface, matching the existing manual registration of the params and upgrade proposal content types. An audit of all 20 atomone-1 mainnet proposals confirms ClientUpdateProposal is the only missing registration; UpgradeProposal is registered defensively as it travels with it in ibc-go.
giunatale
approved these changes
Jul 22, 2026
Collaborator
|
We should backport this to main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v4 mainnet upgrade failed during the gov proposal migration with:
failed to migrate gov proposals: failed to get proposal value: no
concrete type registered for type URL /ibc.core.client.v1.ClientUpdateProposal
against interface *v1beta1.Content
The AtomOne gov module fork defines its own Content interface (atomone.gov.v1beta1.Content), and MsgExecLegacyContent unpacks its content Any against it. ibc-go registers ClientUpdateProposal and UpgradeProposal against the SDK's gov Content interface, but not against ours, so a historical mainnet proposal (#20) wrapping a ClientUpdateProposal failed to unpack during migration.
Register both legacy IBC 02-client proposal content types against the AtomOne Content interface, matching the existing manual registration of the params and upgrade proposal content types.
An audit of all 20 atomone-1 mainnet proposals confirms ClientUpdateProposal is the only missing registration; UpgradeProposal is registered defensively as it travels with it in ibc-go.