fix: enhance KeyStringUtil so that it parses namespaces#326
Merged
akafredperry merged 1 commit intotrunkfrom Jan 20, 2026
Merged
fix: enhance KeyStringUtil so that it parses namespaces#326akafredperry merged 1 commit intotrunkfrom
akafredperry merged 1 commit intotrunkfrom
Conversation
cpswan
approved these changes
Jan 20, 2026
akafredperry
deleted the
fix_KeyStringUtil_to_support_namespace_parsing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Enhanced KeyStringUtil._evalute() method, this is invoked by the constructor and decodes the full key name string into cached values for the getters.
- How I did it
At the end of the existing parsing code, I added code looks for a namespace qualified key name using a regex.
I removed a commented out section that claims to add partial support for namespaces.
- How to verify it
I modified the existing tests that were incorrectly asserting the wrong behaviour.
I added new tests that specifically focus on the getNamespaces behaviour.
- Description for the changelog
fix: namespace parsing in KeyStringUtil which is used in AtClient.getKeys