Conversation
After reset, SX127x hardware leaves REG_MODEM_CONFIG_2 bit 2 (RxPayloadCrcOn) cleared, and RadioLib's SX127x::begin() does not touch it. Upstream RNode firmware explicitly enables CRC on every LoRa transmit and receive path (sx127x::enableCrc in RNode_Firmware.ino:531, sx127x.cpp:160), so a real RNode will silently drop frames that arrive without a valid CRC. This means T-Beam and LoRa32 V2.1 users running the example LoRaInterface cannot interop with real RNodes over LoRa today: outbound packets are dropped at the RNode, inbound packets may be accepted but silently corrupted. Fix by calling chip->setCRC(true) after SX1276::begin() in the SX127x branch of LoRaInterface::start(). The new call is gated on the prior begin() having succeeded, and its own error is folded into state so the existing RADIOLIB_ERR_NONE check catches it. No change required on the SX126x branches: RadioLib's SX126x::begin() already calls setCRC(2), so RAK4631, Heltec V3, and Heltec V4 inherit CRC-on.
Replaces 10-byte random hash in announce with 5-byte random + 5-byte big-endian timestamp to resolve path issues caused by reliance on timestamp. Suggested fix courtesy of @thatSFguy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.