Skip to content

Merging latest master #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
attermann merged 3 commits into from
May 5, 2026
Merged

Merging latest master #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe5cdc0
fix: enable LoRa CRC on SX127x for RNode interop
0xSeren Apr 16, 2026
d538ca2
Merge pull request #45 from 0xSeren/lora-crc-sx127x
attermann Apr 17, 2026
b7bde29
Corrects announce random hash generation
attermann May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions examples/common/lora_interface/LoRaInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,13 @@ bool LoRaInterface::start() {
// begin(freq MHz, bw kHz, sf, cr, syncWord, power dBm, preamble symbols, LNA gain 0=AGC)
int state = chip->begin(frequency, bandwidth, spreading, coding,
RADIOLIB_SX127X_SYNC_WORD, power, 20, 0);
// SX127x hardware default leaves RxPayloadCrcOn=0 and RadioLib's
// SX127x::begin() does not touch it. Upstream RNode firmware enables
// CRC unconditionally (sx127x::enableCrc, RNode_Firmware.ino:531), so
// real RNodes silently drop frames without a CRC. Enable it here to
// interoperate. SX126x branches below inherit CRC-on from
// SX126x::begin() (setCRC(2)), so no explicit call is needed there.
if (state == RADIOLIB_ERR_NONE) state = chip->setCRC(true);

#elif defined(BOARD_RAK4631)
// nRF52: SPI pins must be configured before SPI.begin()
Expand Down
12 changes: 10 additions & 2 deletions src/Destination.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,16 @@ Packet Destination::announce(const Bytes& app_data, bool path_response, const In
else {
Bytes destination_hash = _object->_hash;
//p random_hash = Identity::get_random_hash()[0:5] << int(time.time()).to_bytes(5, "big")
// CBA TODO add in time to random hash
Bytes random_hash = Cryptography::random(Type::Identity::RANDOM_HASH_LENGTH/8);
// CBA Append 5-byte big-endian timestamp to random_hash
uint64_t now = (uint64_t)OS::time();
uint8_t time_bytes[5] = {
(uint8_t)((now >> 32) & 0xFF),
(uint8_t)((now >> 24) & 0xFF),
(uint8_t)((now >> 16) & 0xFF),
(uint8_t)((now >> 8) & 0xFF),
(uint8_t)( now & 0xFF)
};
Bytes random_hash = Cryptography::random(5) + Bytes(time_bytes, 5);

Bytes new_app_data(app_data);
if (new_app_data.empty() && !_object->_default_app_data.empty()) {
Expand Down
Loading