fix(reusable-actionlint): version-check by full path - #6
Merged
Conversation
… active in-step) The install step appended install_dir to $GITHUB_PATH then ran `actionlint --version` in the SAME step, but $GITHUB_PATH only affects subsequent steps, so the bare call exits 127 (command not found). Caller main pipelines went red. Call the binary by full path for the in-step version check; the separate Run step still resolves via PATH.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an in-step PATH resolution issue in the reusable actionlint workflow by invoking actionlint via its installed absolute path immediately after writing to $GITHUB_PATH (which only takes effect for subsequent steps).
Changes:
- Replace
actionlint --versionwith"${install_dir}/actionlint" --versioninside the install step. - Add an inline comment explaining why
$GITHUB_PATHdoesn’t affect the current step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix in-step PATH bug.