feat: searchable scrollback, and a roadmap for v0.5-v0.7 - #345
Open
attson wants to merge 8 commits into
Open
Conversation
Records the direction for the next three versions: treat the existing prefssync engine + sealed SSH vault as the main line, and grow local terminal features and SSH host capabilities as content for it. Scoped out explicitly: the attention-scheduling line (widget forms B/C, running-session pinning, unwired hook events) stays as-is; old P3 (sharing / presence / audit) and P4 (history / replay) drop to backlog.
Adds P5 (local terminal basics + wiring existing config into prefssync), P6 (SSH host capabilities) and P7 (sync layer wrap-up) as items 19-32. Demotes P3 (collaboration) to backlog and defers P4 (history / replay), each with a dated note explaining why. Drops the stale v0.5 label from the completed P2. Trims backlog entries now covered by P5/P7 and records the attention-scheduling follow-ups (running-session pinning, widget forms B/C, unwired hook events) there instead.
…ch to Mod+Shift+F
Reviewer finding: onSearchClose's term?.focus() was a second unconditional direct-focus call site, contradicting the pinned invariant in "does not focus xterm while the pane is still a viewer" (only one such call is allowed, and it must be driver-gated). A viewer pane has disableStdin: !isDriver.value, so returning focus to a read-only terminal buys nothing while risking the iOS soft-keyboard pop this file guards against elsewhere. Route through focusTerminalIfDriver() instead; the search bar itself still opens on viewer panes, gated only by props.focused.
Addresses the "with fixes" ruling on the scrollback-search branch: - TerminalSearchBar: reopening with a retained query re-runs the search instead of showing a stale "no results" (query survives v-if close, counters were reset by the parent) - TerminalSearchBar: counter shows "N+" instead of a lying "0/N" once the addon's highlightLimit caps resultIndex at -1 - TerminalSearchBar: swap hardcoded hex colours for the app's CSS vars where they match exactly, use var(--border) for the near-match, add aria-label to the three buttons, switch the close glyph to match the other six close buttons in the app - TerminalView.test.ts: pin onSearchFind's empty-query reset branch, tie "search bar is positioned" back to .term-view being the actual positioning context via styleBlockFor, tighten two unbounded [\s\S]*? regexes into body-scoped matches - Docs: fix stale Cmd/Ctrl+F sidebar-search binding (now Shift+F) in the published remote-takeover guide and the architecture spec; correct the roadmap's shipped-package-name/shortcut claims for item 19 and the same errors in the source design spec, plus its now-stale Status header; bump the roadmap's version/date line to the actual latest tag; extend the plan's manual QA checklist with the reopen-retains-query case Rebuilt the web embed (internal/relay/web-dist) to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two things, in order: a direction spec for the next three versions, then the first item it schedules.
Direction (3 docs commits).
docs/superpowers/specs/2026-08-16-sync-layer-roadmap-design.mdpicks the config-sync layer as the through-line for v0.5-v0.7. The reasoning:internal/prefssync+desktop/ssh_sync.goalready implement per-key LWW sync plusaccount_keysealed envelopes, but only 8 keys are wired to it — while the roadmap backlog is full of items (font, size, start directory, env vars, shortcut bindings) that are exactly the content that engine is missing. Treating them as one line instead of two backlogs means each capability also buys cross-device consistency.docs/roadmap.mdis rewritten around that: new P5 / P6 / P7 sections as items 19-32, old P3 (collaboration) demoted to backlog and P4 (history/replay) deferred, each with a dated note. The stalev0.5label comes off the completed P2.Item 19 — terminal scrollback search (5 commits).
Mod+F(⌘F / Ctrl+F) opens a search bar over the focused pane; typing searches incrementally, matches highlight, Enter / Shift+Enter step through, a counter shows position over total, Esc closes and clears.How
terminal.searchjoins the shortcut registry onMod+KeyF. The session-sidebar search moves toMod+Shift+KeyF— user-visible behavior change, matching iTerm2 / Ghostty / VS Code where ⌘F searches the terminal.TerminalSearchBar.vueis self-contained: it owns the query and the key semantics and knows nothing about xterm, so it is mount-testable (TerminalView.vueis not).App.vuebumps one monotonic counter, drilled throughPaneGridto every pane; each pane opens its bar only whenprops.focused.xterm-addon-search@^0.13.0— this repo is on xterm v5, so@xterm/addon-search(v6) would be an API mismatch.Testing
go vet ./...clean;go test ./desktop/passing.internal/relay/web-dist/rebuilt on Node 20 and verified drift-free twice, so CI's embed gate passes.Not covered by automation: nine manual GUI checks (plan file, Task 3 Step 9). A headless agent cannot drive the desktop GUI, so this is the remaining gate. Check 9 is the one worth running first — search, Esc, reopen — it covers a real bug the whole-branch review caught, where a retained query rendered a false "No results" until the next keystroke.
Notes for the reviewer
onSearchCloseroutes through the existingfocusTerminalIfDriver()rather than callingterm?.focus()directly. This is load-bearing:TerminalView.test.tspins exactly one direct focus site, because stray xterm refocus pops the iOS soft keyboard, and on the relay web UI the stricterfocusTerminalForPaneActivation()would drop focus tobodyon Esc.