Skip to content

fix: closing-audit findings — stranger-safe launch keys, doc accuracy#16

Merged
atyrode merged 1 commit into
mainfrom
fix/closing-audit
Jul 17, 2026
Merged

fix: closing-audit findings — stranger-safe launch keys, doc accuracy#16
atyrode merged 1 commit into
mainfrom
fix/closing-audit

Conversation

@atyrode

@atyrode atyrode commented Jul 17, 2026

Copy link
Copy Markdown
Owner

The extraction's closing audit ran a "stranger test" (scrubbed env, no author infrastructure) and doc-vs-code verification. Fixes:

Real bugs

  • m hard-exited (code: not found: omp-managed) for anyone without the dotfiles wrapper — now degrades omp-managedomp as the docs always claimed; an explicit CODE_OMP still fails loudly (operator config is never silently substituted)
  • u killed the TUI when no sandbox binary existed — now hidden from help and inert (the sandbox never falls back to plain omp: that would run unsandboxed)

Polish

  • generate init filters thinking levels to the generator's scale, so an omp exposing extras like "off" fails in the step that caused it, not one step later
  • configuration.md: default vault-manifest path documented; missing keys added (r, ?, pgup/pgdn, vim aliases)
  • status.md: shipped-flake bullet retired; vault atyrode/ namespace noted
  • bare #N comment references qualified as atyrode/dotfiles#N

Full suite green; gofmt/vet clean.

🤖 Generated with Claude Code

Two real bugs for users without the author's wrapper binaries:

- the m (managed) launch now degrades omp-managed -> omp, matching the
  documented fallback chain, instead of hard-exiting when the dotfiles
  wrapper name is absent; an explicit CODE_OMP still fails loudly
- the u (sandbox) key is hidden from the help and inert when neither
  CODE_OMP_UNTRUSTED nor ompu exists, instead of killing the TUI on exec

Plus doc/comment accuracy:

- generate init filters thinking levels to the generator's scale (omp
  can expose extras like "off" that made init succeed and generate fail)
- docs/configuration.md documents the default vault-manifest path and
  the missing keys (r, ?, pgup/pgdn, vim aliases)
- docs/status.md: flake bullet retired (shipped), vault namespace noted
- bare dotfiles issue/PR numbers in comments qualified as
  atyrode/dotfiles#N so they stop autolinking into this repo's tracker

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@atyrode
atyrode enabled auto-merge (squash) July 17, 2026 00:09
@atyrode
atyrode merged commit 696f619 into main Jul 17, 2026
1 check passed
@atyrode
atyrode deleted the fix/closing-audit branch July 17, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant