Skip to content

Filtering feature

Jump to bottom
Aurélien PIERRE edited this page May 20, 2022 · 13 revisions

The new filtering feature, forcefully introduced for darktable 4.0, was the straw that made the camel's back break and made me realized that I had been working with a team of idiots for too long, which was cause to start this fork. It is a solution in search for a problem, over-engineered, introducing features that nobody needed in the worst possible way, under cover of what started as a mere refactoring. Then, idiots got trigger-happy and couldn't resist adding bloat to what was just refactored, just because they could. Oversight of the problem to solve was long lost, because there was no problem in the first place.

A quick log for shit and giggles of technical debt diff from the new filtering feature.

+x / -y are the number of lines of code added/removed. For a given feature, best practices are to have the lowest number of code lines at the end because each line is a chance of bug and long code is hard to maintain, debug and extend. See overengineering

  • collect filtering widgets #11066 : +7631 / -2113
  • Filename filter speedup #11550 : +65 / -85
  • collect: fix range selection and click #11636 : +55 / -57
  • range : allow shift-click to select a range #11665 : + 7 / -0
  • filtering : add grouping filter #11721 : + 817 / -29
  • range : reset bounds correctly when typing in entries #11807 : +7 / -2
  • filters : keep off/remove visible but dimmed if pinned #11811 : +8 / -9
  • filtering : fix an issue with conf value overwritting #11819 : +17 / -5
  • filters : update rating numbers correctly #11809 : +57 / - 37
  • filters : always show the pin icon #11808 : +44 / -53

Total: + 8708 / -2390

Same for the phweyland's version, which achieved mostly the same goal minus the shitload of configuration options:

  • Add text & color label filters #10694 : +502 / -87
  • text filter: don't add wildcards on empty entry #11264 : +13 / -10
  • Text filter: fix bug on query #11267 : +6 / -7
  • color label filter: inverts icons symbols #11293 : +4 / -8
  • filter (text & colors label): save their state between dt sessions #11303 : +134 / -94

Total: +659 / -206

PR sort-of merging both features:

  • recent history and rating filters "soft" revert #11801 : + 793 / -46

Next time a refactoring project is started in darktable, please kill it before it ends.

© 2022 - Aurélien PIERRE

Clone this wiki locally