Add passive arrow mode#79
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds a new passive Arrow Mode to the ClickLight overlay pipeline, allowing users to draw persistent on-screen arrow annotations during drag gestures, plus a Clear Arrows action (with a default global shortcut) wired through the app’s menu/UI/settings/profile/hotkey stack.
Changes:
- Introduces
showArrowModesetting and new shortcut actions (toggleArrowMode,clearArrows) with UserDefaults + profile persistence. - Wires Arrow Mode + Clear Arrows into the status menu, settings UI, and hotkey handling (including Laser Pointer mutual exclusion).
- Extends overlay rendering to create, draw, and clear arrow annotations.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/ClickLight/StatusController.swift | Adds Arrow Mode toggle and Clear Arrows menu item; enforces mutual exclusion with Laser Pointer and disables drag trail appropriately. |
| Sources/ClickLight/SettingsStore.swift | Persists showArrowMode and new hotkey bindings via UserDefaults keys/defaults and ClickSettings. |
| Sources/ClickLight/OverlayCoordinator.swift | Allows overlay updates while Arrow Mode is enabled and adds a clearArrows() broadcast to per-screen overlays. |
| Sources/ClickLight/HotKeyBinding.swift | Adds new ClickShortcutAction cases, titles, event IDs, and default binding for Clear Arrows. |
| Sources/ClickLight/ClickProfileStore.swift | Persists showArrowMode in profiles with backwards-compatible decoding. |
| Sources/ClickLight/ClickOverlayWindow.swift | Forwards clearArrows() to the overlay view. |
| Sources/ClickLight/ClickOverlayView.swift | Implements arrow annotation capture/drawing/clearing and integrates it into the render loop and drag suppression. |
| Sources/ClickLight/ClickLightSettingsView.swift | Adds Arrow Mode toggle and updates “Show Drag” UI disabling/description when Arrow Mode is active. |
| Sources/ClickLight/AppDelegate.swift | Wires Clear Arrows callback from status UI and adds hotkey handling for Arrow Mode + Clear Arrows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ab68b84 to
c3cf848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Control + Option + Command + Cshortcut.Notes
This intentionally uses the same passive observation model as Laser Pointer mode. The overlay stays click-through (
ignoresMouseEvents = true) and does not suppress mouse events, so the app underneath still receives the drag. That means text can still highlight while drawing an arrow, but ClickLight should not trap clicks or block interaction.Laser Pointer and Arrow Mode are mutually exclusive. Disabling ClickLight also turns off Arrow Mode and clears existing arrows.
Testing
swift build./build-app.sh